>>5883421>Can I get some crit on this?Your biggest problem is that you don't know how to draw ellipses and don't understand perspective, thus you were unable to draw these ellipses in perspective. Which is okay but there are too many difficult factors coming into play here (perspective, color, material) and you should just focus on one, your lack of spatial thinking betrays your skill level. The glasses don't look like convincing cylinders in a 3D environment, they look like random shapes, because the top and bottom ellipses don't match and don't follow a perspective.
I would really recommend you draw from life, objects such as glasses and boxes, so that you understand how they work in space. Photos don't work for this as well as life. Before drawing such a piece for example, place a glass in front of you and attempt to draw it, it will enhance your spatial thinking skills.
You have also got a problem with rendering the feeling of the material so your glass doesn't look like glass and your ice doesn't look like ice, watch some videos on materials, draw materials from life or do an exercise in digital painting like a series of boxes/props each representing a different material. Ice and glass should look like it's reflecting a lot of light from the light source that's hitting the surface but here it just looks like color mush. It is partly because of your aforementioned lack of spatial understanding - perspective knowledge helps us understand which planes are hit by light and which are in shadow. So perspective is the most important for you.
Good resources for perspective and how light interacts with it are How to Render and How to Draw by Scott Robertson but they are very mechanical and autistic so I would really recommend you study from life a lot. Moderndayjames channel on youtube is really clickbaitey but can be okay as an introduction, he has a playlist on basics of perspective and a video on ellipses I think.
The colors themselves are nice, very vibrant.